Add PCL package #1891

planetmarshall · 2020-06-13T10:51:01Z

Specify library name and version: pcl/1.11.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Morwenn · 2020-06-13T12:36:38Z

I made a basic PCL recipe for Conan some time ago and I've got a few comments regarding what differs:

I decided to prefix many options with with_ or module_ to make it easier to make a difference between what drags in another optional dependency and what requires to build a PCL module. Also it avoids names like twod which isn't really pretty.

I used the following code to handle either static or dynamic dependencies:

self._cmake.definitions["PCL_SHARED_LIBS"] = self.options.shared
self._cmake.definitions["PCL_BUILD_WITH_BOOST_DYNAMIC_LINKING_WIN32"] = self.options["boost"].shared
self._cmake.definitions["PCL_BUILD_WITH_FLANN_DYNAMIC_LINKING_WIN32"] = self.options["flann"].shared
if self.options.with_qhull:
    self._cmake.definitions["PCL_BUILD_WITH_QHULL_DYNAMIC_LINKING_WIN32"] = self.options["qhull"].shared

I also had to add the following lines to the CMakeLists.txt to handle both static and dynamic flann. It's not pretty but it did the job:

if (CONAN_COMPILE_DEFINITIONS_FLANN MATCHES "FLANN_STATIC")
    set(FLANN_USE_STATIC ON)
endif()

Apparently I didn't have to explicitly set any _ROOT CMake variable, I don't know whether they're useful here.

There's a number of reasons I had not proposed the recipe so far: Conan Center still lacks some of the main dependencies like VTK, which many people are likely to want. I considered adding a self.requires("vtk/x.x.x") that would require a package that doesn't exist but could be overriden but I don't think that it's something we want on Conan Center. Also I think that PCL config files export a bunch of CMake variables that wouldn't be automatically generated by Conan generators, and I'm not sure whether this is likely to cause problems.

planetmarshall · 2020-06-13T13:00:42Z

Thanks.

Apparently I didn't have to explicitly set any _ROOT CMake variable, I don't know whether they're useful here.

I'm not sure how that would work, since PCL's find module looks explicitly for the QHull header file, and since no Conan-center packages are distributed with CMake or Pkgconfig files, I don't know how else it would find the QHull conan package.

planetmarshall · 2020-06-15T18:55:34Z

This seems to have been pending for a while. Any update on what it's doing? Is it just in a build queue? It would be useful to have visibility on the CI process for contributors.

uilianries

Thanks for all your effort. Please take a look on my review.

recipes/pcl/all/conanfile.py

recipes/pcl/all/test_package/CMakeLists.txt

recipes/pcl/all/test_package/conanfile.py

planetmarshall · 2020-06-16T07:37:25Z

Thanks for all your effort. Please take a look on my review.

Thanks for taking the time. I'll go through those as soon as I get a chance.

On the subject of options and dependencies - PCL is a large package that still has a few dependencies not provided by Conan (notably VTK).

One approach would be to remove options for which a conan dependency exists in the index (eg Qhull), but retain those that allow the end-user to still use the package without providing those dependencies themselves.

Inspired from conan-io#1891

@maksim-petukhov

* Add pcl PointCloudLibrary package Inspired from #1891 * pcl: misc recipe tweaks * Update recipes/pcl/all/conanfile.py Co-authored-by: Martin Valgur <martin.valgur@gmail.com> * pcl: Further fixes to Conan targets use in CMake * pcl: Fix buggy OpenNI detection if libusb missing * pcl: Fix PCL CMake config breaking OpenGL detection * pcl: Fix _add_component() bugs * pcl: add TODOs for missing Conan packages * pcl: set_property("cmake_find_mode", "both") * pcl: more accurate modelling of PCL components * pcl: tidy description * Enable opengl event if with_vtk is false - Enable opengl event if with_vtk is false as done in PCL CMakeLists.txt * Revert "Enable opengl event if with_vtk is false" This reverts commit c4be26d. * Enable opengl only if with_vtk==True * test is_msvc() method * test is_msvc_static_runtime * pcl: make components optional, add full dependency info * pcl: fixes to the component system * pcl: set OpenGL_GL_PREFERENCE=GLVND * pcl: fix _extra_libs handling * pcl: fix CUDA support * pcl: add all VTK system package variants * pcl: add missing transitive_headers=True based on installed header includes * pcl: add ws2_32 dep on Windows * Restore is_msvc_static_runtime import * pcl: fix Conan v1 issue * pcl: new add_build_type_postfix option, fix library naming on Windows * Take into account @maksim-petukhov remark * Take into account @valgur remark * Take into account maksim-petukhov remark * Set instantiate_only_core_point_types option at True * pcl: restore zlib dependency * pcl: adjust precompile_only_core_point_types name, add comment Based on https://github.com/PointCloudLibrary/pcl/blob/3ed96c246e5c873713ec670b895469d09149a552/cmake/pcl_options.cmake#L49 * Add rm to prevent PDBs files install --------- Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

jcar87 · 2023-08-22T14:18:20Z

Closed via #18389

@maksim-petukhov

* Add pcl PointCloudLibrary package Inspired from conan-io#1891 * pcl: misc recipe tweaks * Update recipes/pcl/all/conanfile.py Co-authored-by: Martin Valgur <martin.valgur@gmail.com> * pcl: Further fixes to Conan targets use in CMake * pcl: Fix buggy OpenNI detection if libusb missing * pcl: Fix PCL CMake config breaking OpenGL detection * pcl: Fix _add_component() bugs * pcl: add TODOs for missing Conan packages * pcl: set_property("cmake_find_mode", "both") * pcl: more accurate modelling of PCL components * pcl: tidy description * Enable opengl event if with_vtk is false - Enable opengl event if with_vtk is false as done in PCL CMakeLists.txt * Revert "Enable opengl event if with_vtk is false" This reverts commit c4be26d. * Enable opengl only if with_vtk==True * test is_msvc() method * test is_msvc_static_runtime * pcl: make components optional, add full dependency info * pcl: fixes to the component system * pcl: set OpenGL_GL_PREFERENCE=GLVND * pcl: fix _extra_libs handling * pcl: fix CUDA support * pcl: add all VTK system package variants * pcl: add missing transitive_headers=True based on installed header includes * pcl: add ws2_32 dep on Windows * Restore is_msvc_static_runtime import * pcl: fix Conan v1 issue * pcl: new add_build_type_postfix option, fix library naming on Windows * Take into account @maksim-petukhov remark * Take into account @valgur remark * Take into account maksim-petukhov remark * Set instantiate_only_core_point_types option at True * pcl: restore zlib dependency * pcl: adjust precompile_only_core_point_types name, add comment Based on https://github.com/PointCloudLibrary/pcl/blob/3ed96c246e5c873713ec670b895469d09149a552/cmake/pcl_options.cmake#L49 * Add rm to prevent PDBs files install --------- Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

Add PCL package

78029bd

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 13, 2020

This comment has been minimized.

Sign in to view

Fix hook errors

07d0522

planetmarshall force-pushed the pcl branch from 316b5b7 to 07d0522 Compare June 13, 2020 11:42

This comment has been minimized.

Sign in to view

planetmarshall added 3 commits June 13, 2020 14:55

select correct version of flann library

fd43a92

rename class

8774793

rename module options

32fef4e

This comment has been minimized.

Sign in to view

rename options and add opengl requirement

8b74bde

planetmarshall force-pushed the pcl branch from 5510dd4 to 8b74bde Compare June 13, 2020 15:29

uilianries requested changes Jun 15, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Jun 16, 2020

planetmarshall added 6 commits June 28, 2020 12:57

Remove most package options and just use sensible defaults

2c755e9

use cmake to specify subfolder name

843cf55

Address PR comments

9050c8d

Use cmake find package generator

6b6ddb5

call convex hull operation in test package

3cc5c64

remove requirement for qhull to be static

3c21176

This comment has been minimized.

Sign in to view

planetmarshall requested a review from uilianries June 28, 2020 18:29

This comment has been minimized.

Sign in to view

remove fpic for windows

13125af

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 9, 2023

Add pcl PointCloudLibrary package

adc1a5f

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 9, 2023

Add pcl PointCloudLibrary package

2fc62d3

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 9, 2023

Add pcl PointCloudLibrary package

db9dcc5

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 10, 2023

Add pcl PointCloudLibrary package

9175395

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 10, 2023

Add pcl PointCloudLibrary package

d1fd5dd

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 10, 2023

Add pcl PointCloudLibrary package

d155055

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 11, 2023

Add pcl PointCloudLibrary package

cb160d0

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 17, 2023

Add pcl PointCloudLibrary package

caeea5b

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 17, 2023

Add pcl PointCloudLibrary package

3e2260c

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 18, 2023

Add pcl PointCloudLibrary package

c591c38

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 19, 2023

Add pcl PointCloudLibrary package

6968f88

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 19, 2023

Add pcl PointCloudLibrary package

bce06ad

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 19, 2023

Add pcl PointCloudLibrary package

f3f14bf

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 19, 2023

Add pcl PointCloudLibrary package

684cfe3

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 19, 2023

Add pcl PointCloudLibrary package

b50cdeb

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 21, 2023

Add pcl PointCloudLibrary package

9391653

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 21, 2023

Add pcl PointCloudLibrary package

a7af74e

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 24, 2023

Add pcl PointCloudLibrary package

ad40b51

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 25, 2023

Add pcl PointCloudLibrary package

77e5a30

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Jul 26, 2023

Add pcl PointCloudLibrary package

59fca12

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Aug 7, 2023

Add pcl PointCloudLibrary package

078a9c8

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Aug 7, 2023

Add pcl PointCloudLibrary package

0cc3879

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Aug 8, 2023

Add pcl PointCloudLibrary package

c4695ed

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Aug 8, 2023

Add pcl PointCloudLibrary package

681e986

Inspired from conan-io#1891

EstebanDugueperoux2 added a commit to EstebanDugueperoux2/conan-center-index that referenced this pull request Aug 9, 2023

Add pcl PointCloudLibrary package

d8a1d15

Inspired from conan-io#1891

jcar87 closed this Aug 22, 2023

planetmarshall deleted the pcl branch August 22, 2023 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PCL package #1891

Add PCL package #1891

planetmarshall commented Jun 13, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Morwenn commented Jun 13, 2020

planetmarshall commented Jun 13, 2020

This comment has been minimized.

planetmarshall commented Jun 15, 2020

uilianries left a comment

planetmarshall commented Jun 16, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jcar87 commented Aug 22, 2023

Add PCL package #1891

Add PCL package #1891

Conversation

planetmarshall commented Jun 13, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Morwenn commented Jun 13, 2020

planetmarshall commented Jun 13, 2020

This comment has been minimized.

planetmarshall commented Jun 15, 2020

uilianries left a comment

Choose a reason for hiding this comment

planetmarshall commented Jun 16, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jcar87 commented Aug 22, 2023